13 Commits

Author	SHA1	Message	Date
Mikhail Kilin	dec60ea74e	fix: mark incoming messages as read when opening chat and load all history ... Fixes two critical bugs: 1. Unread badge not clearing when opening chat - incoming messages weren't marked as viewed 2. Only last 2-3 messages loaded instead of full history due to incorrect break condition Changes: - Add incoming message IDs to pending_view_messages queue on chat open - Remove premature break in get_chat_history() that stopped after 2 messages - Add FakeTdClient.pending_view_messages field for testing - Implement process_pending_view_messages() in FakeTdClient Tests added: - test_incoming_message_shows_unread_badge: verify "(1)" appears for unread - test_opening_chat_clears_unread_badge: verify badge clears after opening - test_opening_chat_loads_many_messages: verify all 50 messages load, not just last few All 28 chat_list tests pass.	2026-02-04 02:07:47 +03:00
Mikhail Kilin	7b2dd6c9a9	refactor: encapsulate auth fields (Group 1/5) ... Фаза 1, Подход 2 - постепенная инкапсуляция полей App. Changes: - src/app/mod.rs: сделаны приватными phone_input, code_input, password_input - src/input/auth.rs: замены на phone_input_mut(), code_input_mut(), password_input_mut() - src/ui/auth.rs: замены на phone_input(), code_input(), password_input() - tests/helpers/app_builder.rs: замены на set_phone_input(), set_code_input(), set_password_input() Используются существующие геттеры/сеттеры (были добавлены ранее). Progress: Group 1/5 complete (auth fields) Next: Group 2 (UI state: screen, is_loading, needs_redraw, is_searching) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-02-02 17:56:34 +03:00
Mikhail Kilin	8e48d076de	refactor: implement trait-based DI for TdClient and fix stack overflow ... Implement complete trait-based dependency injection pattern for TdClient to enable testing with FakeTdClient mock. Fix critical stack overflow bugs caused by infinite recursion in trait implementations. Breaking Changes: - App is now generic: App<T: TdClientTrait = TdClient> - All UI and input handlers are generic over TdClientTrait - TdClient methods now accessed through trait interface New Files: - src/tdlib/trait.rs: TdClientTrait definition with 40+ methods - src/tdlib/client_impl.rs: TdClientTrait impl for TdClient - tests/helpers/fake_tdclient_impl.rs: TdClientTrait impl for FakeTdClient Critical Fixes: - Fix stack overflow in send_message, edit_message, delete_messages - Fix stack overflow in forward_messages, current_chat_messages - Fix stack overflow in current_pinned_message - All methods now call message_manager directly to avoid recursion Testing: - FakeTdClient supports configurable auth_state for auth screen tests - Added pinned message support in FakeTdClient - All 196+ tests passing (188 tests + 8 benchmarks) Dependencies: - Added async-trait = "0.1" Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-02-02 05:42:19 +03:00
Mikhail Kilin	2b04b785c0	refactor: cleanup unused code and warnings ... Comprehensive cleanup of unused methods, dead code, and compiler warnings: ## Removed Methods (15): - Duplicate delegation methods: is_authenticated, get_typing_text, get_user_name from TdClient - Obsolete methods: TdClient::init() (duplicated in main.rs) - Unused getters: UserCache::{get_username, get_name, get_user_id_by_chat} - Unused builder methods: MessageBuilder::{edited, add_reaction} - Unused utility: ChatState::is_normal() - Dead code: HotkeysConfig::{matches, key_matches} (kept for tests) - Unused method: UserCache::register_private_chat() - Getter replaced with direct field access: MessageInfo::edit_date() ## Removed Module: - error.rs - Unused error handling module (TeletuiError, ErrorVariant, IntoTeletuiError) ## Removed Constants (8): - EMOJI_PICKER_COLUMNS, EMOJI_PICKER_ROWS, MAX_INPUT_HEIGHT - MIN_TERMINAL_WIDTH, MIN_TERMINAL_HEIGHT - TDLIB_CHAT_LIMIT, MAX_USERNAME_DISPLAY_LENGTH, MESSAGE_TEXT_INDENT ## Fixed Warnings: - Removed unused imports (8 instances) - Fixed unreachable patterns (10 instances) - Fixed irrefutable if let patterns (2 instances) - Fixed unused variables (1 instance) - Removed dead_code annotations where appropriate ## Improvements: - Integrated Config::load_credentials() into TdClient::new() for better credential management - Replaced edit_date() getter with direct field access (message.metadata.edit_date) - Updated tests to use direct field access instead of removed getters ## Test Results: All tests passing: 499 passed, 0 failed Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-02-01 18:57:55 +03:00
Mikhail Kilin	c5896b7f14	tests	2026-01-31 23:02:53 +03:00
Mikhail Kilin	644e36597d	fixes	2026-01-31 03:48:50 +03:00
Mikhail Kilin	43960332d9	refactor: restructure MessageInfo with logical field grouping (P2.6) ... Сгруппированы 16 плоских полей MessageInfo в 4 логические структуры для улучшения организации кода и maintainability. Новые структуры: - MessageMetadata: id, sender_name, date, edit_date - MessageContent: text, entities - MessageState: is_outgoing, is_read, can_be_edited, can_be_deleted_* - MessageInteractions: reply_to, forward_from, reactions Изменения: - Добавлены 4 новые структуры в tdlib/types.rs - Обновлена MessageInfo для использования новых структур - Добавлен конструктор MessageInfo::new() для удобного создания - Добавлены getter методы (id(), text(), sender_name() и др.) для удобного доступа - Обновлены все места создания MessageInfo (convert_message) - Обновлены все места использования (~200+ обращений): * ui/messages.rs: рендеринг сообщений * app/mod.rs: логика приложения * input/main_input.rs: обработка ввода и копирование * tdlib/client.rs: обработка updates * Все тестовые файлы (14 файлов) Преимущества: - Логическая группировка данных - Проще понимать структуру сообщения - Легче добавлять новые поля в будущем - Улучшенная читаемость кода Статус: Priority 2 теперь 80% (4/5 задач) - ✅ Error enum - ✅ Config validation - ✅ Newtype для ID - ✅ MessageInfo реструктуризация - ⏳ MessageBuilder pattern Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-01-31 01:45:54 +03:00
Mikhail Kilin	7081a886ad	refactor: implement newtype pattern for IDs (P2.4) ... Добавлены типобезопасные обёртки ChatId, MessageId, UserId для предотвращения смешивания разных типов идентификаторов на этапе компиляции. Изменения: - Создан src/types.rs с тремя newtype структурами - Реализованы методы: new(), as_i64(), From<i64>, Display - Добавлены traits: Hash, Eq, Serialize, Deserialize - Обновлены 15+ модулей для использования новых типов: * tdlib: types.rs, chats.rs, messages.rs, users.rs, reactions.rs, client.rs * app: mod.rs, chat_state.rs * input: main_input.rs * tests: app_builder.rs, test_data.rs - Исправлены 53 ошибки компиляции связанные с type conversions Преимущества: - Компилятор предотвращает смешивание разных типов ID - Улучшенная читаемость кода (явные типы вместо i64) - Самодокументирующиеся типы Статус: Priority 2 теперь 60% (3/5 задач) - ✅ Error enum - ✅ Config validation - ✅ Newtype для ID - ⏳ MessageInfo реструктуризация - ⏳ MessageBuilder pattern Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-01-31 01:33:18 +03:00
Mikhail Kilin	bba5cbd22d	fixes	2026-01-30 23:55:01 +03:00
Mikhail Kilin	433233d766	commit	2026-01-30 17:26:21 +03:00
Mikhail Kilin	4deb0fbe00	commit	2026-01-30 15:07:13 +03:00
Mikhail Kilin	126c7482af	fixes	2026-01-29 01:22:57 +03:00
Mikhail Kilin	68a2b7a982	fixes	2026-01-28 11:39:21 +03:00