3 Commits

Author	SHA1	Message	Date
Mikhail Kilin	92cc89a2e6	feat: disable desktop notifications by default ... Changed NotificationManager::new() to set enabled: false This completely disables all desktop notifications in the app. Modified: - src/notifications.rs:32 - enabled: true -> false Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-02-05 21:55:51 +03:00
Mikhail Kilin	7dbb2209c8	fix: use char boundaries instead of byte indices for UTF-8 strings in notifications ... PANIC FIX: Notification preview truncation was using byte indices (`[..147]`) instead of char boundaries, causing panic when truncating UTF-8 strings containing multi-byte characters (Cyrillic, emoji, etc.). Error message: "byte index 147 is not a char boundary; it is inside 'п' (bytes 146..148)" Fix: - Replace `beautified.len() > 150` with `beautified.chars().count() > MAX_PREVIEW_CHARS` - Replace `&beautified[..147]` with `beautified.chars().take(MAX_PREVIEW_CHARS).collect()` - Add constant MAX_PREVIEW_CHARS = 147 for clarity This ensures we truncate at character boundaries, not byte boundaries, preventing panics on multi-byte UTF-8 sequences. Impact: Notifications for messages with Russian/emoji text crashed the app. Root cause: Classic Rust UTF-8 indexing mistake - slicing by bytes instead of characters. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-02-05 13:06:40 +03:00
Mikhail Kilin	bea0bcbed0	feat: implement desktop notifications with comprehensive filtering ... Implemented Phase 10 (Desktop Notifications) with three stages: notify-rust integration, smart filtering, and production polish. Stage 1 - Base Implementation: - Add NotificationManager module (src/notifications.rs, 350+ lines) - Integrate notify-rust 4.11 with feature flag "notifications" - Implement NotificationsConfig in config.toml (enabled, only_mentions, show_preview) - Add notification_manager field to TdClient - Create configure_notifications() method for config integration - Hook into handle_new_message_update() to send notifications - Send notifications for messages outside current chat - Format notification body with sender name and message preview Stage 2 - Smart Filtering: - Sync muted chats from Telegram (sync_muted_chats method) - Filter muted chats from notifications automatically - Add MessageInfo::has_mention() to detect @username mentions - Implement only_mentions filter (notify only when mentioned) - Beautify media labels with emojis (📷 📹 🎤 🎨 📎 etc.) - Support 10+ media types in notification preview Stage 3 - Production Polish: - Add graceful error handling (no panics on notification failure) - Implement comprehensive logging (tracing::debug!/warn!) - Add timeout_ms configuration (0 = system default) - Add urgency configuration (low/normal/critical, Linux only) - Platform-specific #[cfg] for urgency support - Log all notification skip reasons at debug level Hotkey Change: - Move profile view from 'i' to Ctrl+i to avoid conflicts Technical Details: - Cross-platform support (macOS, Linux, Windows) - Feature flag for optional notifications support - Graceful fallback when notifications unavailable - LRU-friendly muted chats sync - Test coverage for all core notification logic - All 75 tests passing Files Changed: - NEW: src/notifications.rs - Complete NotificationManager - NEW: config.example.toml - Example configuration with notifications - Modified: Cargo.toml - Add notify-rust 4.11 dependency - Modified: src/config/mod.rs - Add NotificationsConfig struct - Modified: src/tdlib/types.rs - Add has_mention() method - Modified: src/tdlib/client.rs - Add notification integration - Modified: src/tdlib/update_handlers.rs - Hook notifications - Modified: src/config/keybindings.rs - Change profile to Ctrl+i - Modified: tests/* - Add notification config to tests Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-02-05 01:27:44 +03:00