refactor: implement trait-based DI for TdClient and fix stack overflow

Implement complete trait-based dependency injection pattern for TdClient to enable testing with FakeTdClient mock. Fix critical stack overflow bugs caused by infinite recursion in trait implementations. Breaking Changes: - App is now generic: App<T: TdClientTrait = TdClient> - All UI and input handlers are generic over TdClientTrait - TdClient methods now accessed through trait interface New Files: - src/tdlib/trait.rs: TdClientTrait definition with 40+ methods - src/tdlib/client_impl.rs: TdClientTrait impl for TdClient - tests/helpers/fake_tdclient_impl.rs: TdClientTrait impl for FakeTdClient Critical Fixes: - Fix stack overflow in send_message, edit_message, delete_messages - Fix stack overflow in forward_messages, current_chat_messages - Fix stack overflow in current_pinned_message - All methods now call message_manager directly to avoid recursion Testing: - FakeTdClient supports configurable auth_state for auth screen tests - Added pinned message support in FakeTdClient - All 196+ tests passing (188 tests + 8 benchmarks) Dependencies: - Added async-trait = "0.1" Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-02 05:42:19 +03:00
parent ed5a4f9c72
commit 8e48d076de
38 changed files with 1053 additions and 161 deletions
--- a/src/tdlib/client_impl.rs
+++ b/src/tdlib/client_impl.rs
@@ -0,0 +1,270 @@
+//! Implementation of TdClientTrait for TdClient
+//!
+//! This file contains the trait implementation that delegates to existing TdClient methods.
+
+use super::client::TdClient;
+use super::r#trait::TdClientTrait;
+use super::{AuthState, ChatInfo, FolderInfo, MessageInfo, ProfileInfo, ReplyInfo, UserCache, UserOnlineStatus};
+use crate::types::{ChatId, MessageId, UserId};
+use async_trait::async_trait;
+use tdlib_rs::enums::{ChatAction, Update};
+
+#[async_trait]
+impl TdClientTrait for TdClient {
+    // ============ Auth methods ============
+    async fn send_phone_number(&self, phone: String) -> Result<(), String> {
+        self.send_phone_number(phone).await
+    }
+
+    async fn send_code(&self, code: String) -> Result<(), String> {
+        self.send_code(code).await
+    }
+
+    async fn send_password(&self, password: String) -> Result<(), String> {
+        self.send_password(password).await
+    }
+
+    // ============ Chat methods ============
+    async fn load_chats(&mut self, limit: i32) -> Result<(), String> {
+        self.load_chats(limit).await
+    }
+
+    async fn load_folder_chats(&mut self, folder_id: i32, limit: i32) -> Result<(), String> {
+        self.load_folder_chats(folder_id, limit).await
+    }
+
+    async fn leave_chat(&self, chat_id: ChatId) -> Result<(), String> {
+        self.leave_chat(chat_id).await
+    }
+
+    async fn get_profile_info(&self, chat_id: ChatId) -> Result<ProfileInfo, String> {
+        self.get_profile_info(chat_id).await
+    }
+
+    // ============ Chat actions ============
+    async fn send_chat_action(&self, chat_id: ChatId, action: ChatAction) {
+        self.send_chat_action(chat_id, action).await
+    }
+
+    fn clear_stale_typing_status(&mut self) -> bool {
+        self.clear_stale_typing_status()
+    }
+
+    // ============ Message methods ============
+    async fn get_chat_history(&mut self, chat_id: ChatId, limit: i32) -> Result<Vec<MessageInfo>, String> {
+        self.get_chat_history(chat_id, limit).await
+    }
+
+    async fn load_older_messages(&mut self, chat_id: ChatId, from_message_id: MessageId) -> Result<Vec<MessageInfo>, String> {
+        self.load_older_messages(chat_id, from_message_id).await
+    }
+
+    async fn get_pinned_messages(&mut self, chat_id: ChatId) -> Result<Vec<MessageInfo>, String> {
+        self.get_pinned_messages(chat_id).await
+    }
+
+    async fn load_current_pinned_message(&mut self, chat_id: ChatId) {
+        self.load_current_pinned_message(chat_id).await
+    }
+
+    async fn search_messages(&self, chat_id: ChatId, query: &str) -> Result<Vec<MessageInfo>, String> {
+        self.search_messages(chat_id, query).await
+    }
+
+    async fn send_message(
+        &mut self,
+        chat_id: ChatId,
+        text: String,
+        reply_to_message_id: Option<MessageId>,
+        reply_info: Option<ReplyInfo>,
+    ) -> Result<MessageInfo, String> {
+        self.message_manager
+            .send_message(chat_id, text, reply_to_message_id, reply_info)
+            .await
+    }
+
+    async fn edit_message(
+        &mut self,
+        chat_id: ChatId,
+        message_id: MessageId,
+        new_text: String,
+    ) -> Result<MessageInfo, String> {
+        self.message_manager
+            .edit_message(chat_id, message_id, new_text)
+            .await
+    }
+
+    async fn delete_messages(
+        &mut self,
+        chat_id: ChatId,
+        message_ids: Vec<MessageId>,
+        revoke: bool,
+    ) -> Result<(), String> {
+        self.message_manager
+            .delete_messages(chat_id, message_ids, revoke)
+            .await
+    }
+
+    async fn forward_messages(
+        &mut self,
+        to_chat_id: ChatId,
+        from_chat_id: ChatId,
+        message_ids: Vec<MessageId>,
+    ) -> Result<(), String> {
+        self.message_manager
+            .forward_messages(to_chat_id, from_chat_id, message_ids)
+            .await
+    }
+
+    async fn set_draft_message(&self, chat_id: ChatId, text: String) -> Result<(), String> {
+        self.set_draft_message(chat_id, text).await
+    }
+
+    fn push_message(&mut self, msg: MessageInfo) {
+        self.push_message(msg)
+    }
+
+    async fn fetch_missing_reply_info(&mut self) {
+        self.fetch_missing_reply_info().await
+    }
+
+    async fn process_pending_view_messages(&mut self) {
+        self.process_pending_view_messages().await
+    }
+
+    // ============ User methods ============
+    fn get_user_status_by_chat_id(&self, chat_id: ChatId) -> Option<&UserOnlineStatus> {
+        self.get_user_status_by_chat_id(chat_id)
+    }
+
+    async fn process_pending_user_ids(&mut self) {
+        self.process_pending_user_ids().await
+    }
+
+    // ============ Reaction methods ============
+    async fn get_message_available_reactions(
+        &self,
+        chat_id: ChatId,
+        message_id: MessageId,
+    ) -> Result<Vec<String>, String> {
+        self.get_message_available_reactions(chat_id, message_id).await
+    }
+
+    async fn toggle_reaction(
+        &self,
+        chat_id: ChatId,
+        message_id: MessageId,
+        reaction: String,
+    ) -> Result<(), String> {
+        self.toggle_reaction(chat_id, message_id, reaction).await
+    }
+
+    fn client_id(&self) -> i32 {
+        self.client_id()
+    }
+
+    async fn get_me(&self) -> Result<i64, String> {
+        self.get_me().await
+    }
+
+    fn auth_state(&self) -> &AuthState {
+        self.auth_state()
+    }
+
+    fn chats(&self) -> &[ChatInfo] {
+        self.chats()
+    }
+
+    fn folders(&self) -> &[FolderInfo] {
+        self.folders()
+    }
+
+    fn current_chat_messages(&self) -> Vec<MessageInfo> {
+        self.message_manager.current_chat_messages.to_vec()
+    }
+
+    fn current_chat_id(&self) -> Option<ChatId> {
+        self.current_chat_id()
+    }
+
+    fn current_pinned_message(&self) -> Option<MessageInfo> {
+        self.message_manager.current_pinned_message.clone()
+    }
+
+    fn typing_status(&self) -> Option<&(UserId, String, std::time::Instant)> {
+        self.typing_status()
+    }
+
+    fn pending_view_messages(&self) -> &[(ChatId, Vec<MessageId>)] {
+        self.pending_view_messages()
+    }
+
+    fn pending_user_ids(&self) -> &[UserId] {
+        self.pending_user_ids()
+    }
+
+    fn main_chat_list_position(&self) -> i32 {
+        self.main_chat_list_position()
+    }
+
+    fn user_cache(&self) -> &UserCache {
+        self.user_cache()
+    }
+
+    fn network_state(&self) -> super::types::NetworkState {
+        self.network_state.clone()
+    }
+
+    fn chats_mut(&mut self) -> &mut Vec<ChatInfo> {
+        self.chats_mut()
+    }
+
+    fn folders_mut(&mut self) -> &mut Vec<FolderInfo> {
+        self.folders_mut()
+    }
+
+    fn current_chat_messages_mut(&mut self) -> &mut Vec<MessageInfo> {
+        self.current_chat_messages_mut()
+    }
+
+    fn clear_current_chat_messages(&mut self) {
+        self.current_chat_messages_mut().clear()
+    }
+
+    fn set_current_chat_messages(&mut self, messages: Vec<MessageInfo>) {
+        *self.current_chat_messages_mut() = messages;
+    }
+
+    fn set_current_chat_id(&mut self, chat_id: Option<ChatId>) {
+        self.set_current_chat_id(chat_id)
+    }
+
+    fn set_current_pinned_message(&mut self, msg: Option<MessageInfo>) {
+        self.set_current_pinned_message(msg)
+    }
+
+    fn set_typing_status(&mut self, status: Option<(UserId, String, std::time::Instant)>) {
+        self.set_typing_status(status)
+    }
+
+    fn pending_view_messages_mut(&mut self) -> &mut Vec<(ChatId, Vec<MessageId>)> {
+        self.pending_view_messages_mut()
+    }
+
+    fn pending_user_ids_mut(&mut self) -> &mut Vec<UserId> {
+        self.pending_user_ids_mut()
+    }
+
+    fn set_main_chat_list_position(&mut self, position: i32) {
+        self.set_main_chat_list_position(position)
+    }
+
+    fn user_cache_mut(&mut self) -> &mut UserCache {
+        self.user_cache_mut()
+    }
+
+    // ============ Update handling ============
+    fn handle_update(&mut self, update: Update) {
+        self.handle_update(update)
+    }
+}
--- a/src/tdlib/mod.rs
+++ b/src/tdlib/mod.rs
@@ -2,17 +2,21 @@
 pub mod auth;
 pub mod chats;
 pub mod client;
+mod client_impl; // Private module for trait implementation
 pub mod messages;
 pub mod reactions;
+pub mod r#trait;
 pub mod types;
 pub mod users;

 // Экспорт основных типов
 pub use auth::AuthState;
 pub use client::TdClient;
+pub use r#trait::TdClientTrait;
 pub use types::{
-    ChatInfo, MessageBuilder, MessageInfo, NetworkState, ProfileInfo, ReplyInfo, UserOnlineStatus,
+    ChatInfo, FolderInfo, MessageBuilder, MessageInfo, NetworkState, ProfileInfo, ReplyInfo, UserOnlineStatus,
 };
+pub use users::UserCache;

 // Re-export ChatAction для удобства
 pub use tdlib_rs::enums::ChatAction;
--- a/src/tdlib/trait.rs
+++ b/src/tdlib/trait.rs
@@ -0,0 +1,125 @@
+//! Trait definition for TdClient to enable dependency injection
+//!
+//! This trait allows tests to use FakeTdClient instead of real TDLib client.
+
+use crate::tdlib::{AuthState, FolderInfo, MessageInfo, ProfileInfo, UserCache, UserOnlineStatus};
+use crate::types::{ChatId, MessageId, UserId};
+use async_trait::async_trait;
+use tdlib_rs::enums::{ChatAction, Update};
+
+use super::ChatInfo;
+
+/// Trait for TDLib client operations
+///
+/// This trait defines the interface for both real and fake TDLib clients,
+/// enabling dependency injection and easier testing.
+#[async_trait]
+pub trait TdClientTrait: Send {
+    // ============ Auth methods ============
+    async fn send_phone_number(&self, phone: String) -> Result<(), String>;
+    async fn send_code(&self, code: String) -> Result<(), String>;
+    async fn send_password(&self, password: String) -> Result<(), String>;
+
+    // ============ Chat methods ============
+    async fn load_chats(&mut self, limit: i32) -> Result<(), String>;
+    async fn load_folder_chats(&mut self, folder_id: i32, limit: i32) -> Result<(), String>;
+    async fn leave_chat(&self, chat_id: ChatId) -> Result<(), String>;
+    async fn get_profile_info(&self, chat_id: ChatId) -> Result<ProfileInfo, String>;
+
+    // ============ Chat actions ============
+    async fn send_chat_action(&self, chat_id: ChatId, action: ChatAction);
+    fn clear_stale_typing_status(&mut self) -> bool;
+
+    // ============ Message methods ============
+    async fn get_chat_history(&mut self, chat_id: ChatId, limit: i32) -> Result<Vec<MessageInfo>, String>;
+    async fn load_older_messages(&mut self, chat_id: ChatId, from_message_id: MessageId) -> Result<Vec<MessageInfo>, String>;
+    async fn get_pinned_messages(&mut self, chat_id: ChatId) -> Result<Vec<MessageInfo>, String>;
+    async fn load_current_pinned_message(&mut self, chat_id: ChatId);
+    async fn search_messages(&self, chat_id: ChatId, query: &str) -> Result<Vec<MessageInfo>, String>;
+
+    async fn send_message(
+        &mut self,
+        chat_id: ChatId,
+        text: String,
+        reply_to_message_id: Option<MessageId>,
+        reply_info: Option<super::ReplyInfo>,
+    ) -> Result<MessageInfo, String>;
+
+    async fn edit_message(
+        &mut self,
+        chat_id: ChatId,
+        message_id: MessageId,
+        new_text: String,
+    ) -> Result<MessageInfo, String>;
+
+    async fn delete_messages(
+        &mut self,
+        chat_id: ChatId,
+        message_ids: Vec<MessageId>,
+        revoke: bool,
+    ) -> Result<(), String>;
+
+    async fn forward_messages(
+        &mut self,
+        to_chat_id: ChatId,
+        from_chat_id: ChatId,
+        message_ids: Vec<MessageId>,
+    ) -> Result<(), String>;
+
+    async fn set_draft_message(&self, chat_id: ChatId, text: String) -> Result<(), String>;
+
+    fn push_message(&mut self, msg: MessageInfo);
+    async fn fetch_missing_reply_info(&mut self);
+    async fn process_pending_view_messages(&mut self);
+
+    // ============ User methods ============
+    fn get_user_status_by_chat_id(&self, chat_id: ChatId) -> Option<&UserOnlineStatus>;
+    async fn process_pending_user_ids(&mut self);
+
+    // ============ Reaction methods ============
+    async fn get_message_available_reactions(
+        &self,
+        chat_id: ChatId,
+        message_id: MessageId,
+    ) -> Result<Vec<String>, String>;
+
+    async fn toggle_reaction(
+        &self,
+        chat_id: ChatId,
+        message_id: MessageId,
+        reaction: String,
+    ) -> Result<(), String>;
+
+    // ============ Getters (immutable) ============
+    fn client_id(&self) -> i32;
+    async fn get_me(&self) -> Result<i64, String>;
+    fn auth_state(&self) -> &AuthState;
+    fn chats(&self) -> &[ChatInfo];
+    fn folders(&self) -> &[FolderInfo];
+    fn current_chat_messages(&self) -> Vec<MessageInfo>;
+    fn current_chat_id(&self) -> Option<ChatId>;
+    fn current_pinned_message(&self) -> Option<MessageInfo>;
+    fn typing_status(&self) -> Option<&(UserId, String, std::time::Instant)>;
+    fn pending_view_messages(&self) -> &[(ChatId, Vec<MessageId>)];
+    fn pending_user_ids(&self) -> &[UserId];
+    fn main_chat_list_position(&self) -> i32;
+    fn user_cache(&self) -> &UserCache;
+    fn network_state(&self) -> super::types::NetworkState;
+
+    // ============ Setters (mutable) ============
+    fn chats_mut(&mut self) -> &mut Vec<ChatInfo>;
+    fn folders_mut(&mut self) -> &mut Vec<FolderInfo>;
+    fn current_chat_messages_mut(&mut self) -> &mut Vec<MessageInfo>;
+    fn clear_current_chat_messages(&mut self);
+    fn set_current_chat_messages(&mut self, messages: Vec<MessageInfo>);
+    fn set_current_chat_id(&mut self, chat_id: Option<ChatId>);
+    fn set_current_pinned_message(&mut self, msg: Option<MessageInfo>);
+    fn set_typing_status(&mut self, status: Option<(UserId, String, std::time::Instant)>);
+    fn pending_view_messages_mut(&mut self) -> &mut Vec<(ChatId, Vec<MessageId>)>;
+    fn pending_user_ids_mut(&mut self) -> &mut Vec<UserId>;
+    fn set_main_chat_list_position(&mut self, position: i32);
+    fn user_cache_mut(&mut self) -> &mut UserCache;
+
+    // ============ Update handling ============
+    fn handle_update(&mut self, update: Update);
+}